Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Append --vault-id to ansible runner command #383

Conversation

SquirrelDeveloper
Copy link
Collaborator

Add --vault-id [email protected] to the command line arguments if 'cmdline' exists in runner_args. This ensures the vault ID is always passed for secure password management.

Add --vault-id [email protected] to the command line arguments if 'cmdline' exists in runner_args. This ensures the vault ID is always passed for secure password management.
@SquirrelDeveloper SquirrelDeveloper added the bug Something isn't working label Oct 15, 2024
@SquirrelDeveloper SquirrelDeveloper added this to the v0.1.21 milestone Oct 15, 2024
SquirrelDevelopper added 6 commits October 15, 2024 11:01
Added comprehensive unit tests for `ssm-ansible-run.py` to validate different flag and parameter combinations. Updated GitHub workflow to include Python tests, ensuring thorough CI coverage.
Updated the command to run Python tests within the CI workflow from 'npm test:python' to 'npm run test:python'. This ensures the correct execution of the Python test script.
Included a new npm script 'test:python' to run Python unit tests located in the Ansible directory using unittest. This update ensures Python tests can be executed consistently within the same workflow as other npm scripts.
Updated the npm "test:python" script to automatically install required Python dependencies from requirements.txt. This ensures that all necessary dependencies are installed before running the tests, improving test reliability and developer experience.
Updated the `test:python:install` script to include the `--break-system-packages` flag. This ensures compatibility with certain Python environments and prevents issues related to system package conflicts during installation.
This change adds the ansible-runner package to the requirements.txt file. It ensures that ansible-runner is available as a dependency for project builds and deployments.
@SquirrelDeveloper SquirrelDeveloper merged commit 7102585 into master Oct 15, 2024
9 checks passed
@SquirrelDeveloper SquirrelDeveloper deleted the 365-bug-some-playbooks-fail-to-execute-attempting-to-decrypt-but-no-vault-secrets-found branch October 15, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] some playbooks Fail to execute "Attempting to decrypt but no vault secrets found"
1 participant